Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migration to Cosmos SDK v0.46 #1217

Merged
merged 114 commits into from
Aug 22, 2022
Merged

feat: migration to Cosmos SDK v0.46 #1217

merged 114 commits into from
Aug 22, 2022

Conversation

robert-zaremba
Copy link
Member

@robert-zaremba robert-zaremba commented Aug 4, 2022

Closes: #603

Description

  • Migration to Cosmos SDK v0.46
  • preliminary oracle tx prioritization
  • upgrade handlers
  • integrated new modules: nft, gov
  • bump IBC to v3.1
  • few cleanups

NOTES

  • I'm using replace to deal with dependencies we had to migrate. In order to build the app, you need to clone our forks of Gravity Bridge, IBC and bech32ibc next to the umee repo.

TODO:

  • migrate tests

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RafilxTenfen RafilxTenfen self-requested a review August 22, 2022 01:33
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged after we fix the Tests / test-unit-cover

@robert-zaremba
Copy link
Member Author

Thanks @RafilxTenfen . I'm going to comment that test and will open a new branch to continue investigating it. It will be a priority to fix it, although we still have other tasks to finish for the release.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #1217 (704be66) into main (bbe878b) will decrease coverage by 0.80%.
The diff coverage is 74.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1217      +/-   ##
==========================================
- Coverage   52.20%   51.39%   -0.81%     
==========================================
  Files          67       68       +1     
  Lines        6827     6841      +14     
==========================================
- Hits         3564     3516      -48     
- Misses       3000     3067      +67     
+ Partials      263      258       -5     
Impacted Files Coverage Δ
x/ibctransfer/keeper/keeper.go 0.00% <ø> (-77.03%) ⬇️
x/leverage/client/cli/tx.go 0.00% <0.00%> (ø)
x/leverage/keeper/genesis.go 2.58% <0.00%> (ø)
x/leverage/simulation/decoder.go 0.00% <0.00%> (ø)
x/leverage/types/codec.go 41.93% <0.00%> (ø)
x/oracle/types/test_utils.go 49.12% <10.00%> (-0.44%) ⬇️
x/leverage/keeper/iter.go 53.57% <33.33%> (ø)
ante/ante.go 58.62% <50.00%> (+2.73%) ⬆️
x/leverage/types/proposal.go 20.00% <50.00%> (-3.08%) ⬇️
x/leverage/keeper/liquidate.go 78.98% <83.33%> (ø)
... and 17 more

@robert-zaremba robert-zaremba mentioned this pull request Aug 22, 2022
4 tasks
@robert-zaremba
Copy link
Member Author

I've removed the go.work integration. It was setting go 1.19 while in other places we use go 1.18. Hence should be done separately. tracking issue: #1260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Umee v3 (Calypso) Upgrade Tracking
5 participants